[Bug 174529] Review Request: clearsilver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clearsilver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174529


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2005-11-29 15:16 EST -------
Initial comments, not a full review:

I'd suggest taking the patches and some other bits from my package of this at
http://cachalot.mine.nu/4/SRPMS/clearsilver-0.10.1-0.1.src.rpm
(most of the issues found below are fixed in it)

All the perl_* and need_buildroot defines can be removed, they work just fine in
the scope of all supported (and some past) Fedora Core versions.

Most of the conditional subpackages could be just be made unconditional, and a
lot of specfile cruft would disappear.

Why isn't the ruby subpackage built by default?

IIRC the java subpackage could be built with FC4+'s java.

The minimum required version of the python* build dependency is probably bogus;
I've built and used this on a FC2 box recently.  (My package has >= 2.1, but I'm
not 100% sure about its correctness.)

"2.4" is hardcoded for the python version in %prep, needs to be fixed.  Ditto
hardcoded python site packages path which would be incorrect for x86_64.

The python subpackage does not require the main package.  This is probably true
for the perl, ruby, and forthcoming ;) java subpackage too.

perllocal.pod cannot be packaged; it'll conflict with other packages.

Perl stuff must be installed into vendor install dirs.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.