[Bug 173544] Review Request: xfce4-genmon-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-genmon-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173544


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2005-11-30 18:28 EST -------
good: 
- rpmlint is clean :)
- License is good (LGPL).
- builds fine on fc4/devel. (with missing BR added, see below)
- installs and runs fine on my fc4 laptop. 
- builds fine in mock under devel if you add missing RB (see below)

nits: 
- Might tell upstream that the spec they ship has the License as BSD, which is
wrong. 

needswork:
- source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
but you have the older version from 2004. 
- missing libxfcegui4-devel BuildRequires. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.