[Bug 169971] Qalculate - A multi-purpose desktop calculator for GNU/Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Qalculate - A multi-purpose desktop calculator for GNU/Linux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169971


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-10 13:17 EST -------
Good:

- package and spec naming OK
- package meets most guidelines
- license is GPL
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 and in mock for rawhide (i386)
- proper use of %find_lang for locales
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- libtool archive not included
- no desktop file needed
- qalc seems to run ok, but I only played very briefly with it

Needswork:

- rpmlint not clean, mainly due to not splitting off header files etc. into a
  separate -devel subpackage
- BuildReqs need a bit of work (see below)
- ldconfig not run in %post/%postun
- package includes static libraries (deprecated in Fedora)
- http://qalculate.sourceforge.net/downloads.html suggests that libxml2 >=
  2.3.8 is a buildreq
- the program will include readline/ncurses support if available at build
  time, so readline-devel & ncurses-devel should be added as buildreqs
- explicit glib2 & libxml2 deps are redundant and should be removed
- the Makefile includes DESTDIR support, which I believe is preferred to
  using %makeinstall
- the README file just includes a URL to visit so isn't really worth including
- the AUTHORS and TODO files probably are worth including as %doc
- license text in COPYING should be included as %doc

Suggestions:

- perhaps split off a separate package for the text-mode qalc program itself
  (maybe called qalculate?)

I'll attach a patch addressing the Needswork issues.


I haven't reviewed a library before so anyone more experienced with those can
please take a look too...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.