[Bug 171039] Review Request: geos

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geos


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171039





------- Additional Comments From rc040203 at freenet.de  2005-10-18 00:05 EST -------
Some random comments:

1. rpmlint

# rpmlint geos-2.1.4-1.i386.rpm
E: geos zero-length /usr/share/doc/geos-2.1.4/ChangeLog

rpmlint is right on this. Simply remove it from the corresponding %doc line.

# rpmlint geos-devel-2.1.4-1.i386.rpm
W: geos-devel no-documentation
Can be ignored.

# rpmlint geos-doc-2.1.4-1.i386.rpm
E: geos-doc arch-dependent-file-in-usr-share
/usr/share/doc/geos-doc-2.1.4/doc/.libs/example
W: geos-doc unstripped-binary-or-object
/usr/share/doc/geos-doc-2.1.4/doc/.libs/example
E: geos-doc arch-dependent-file-in-usr-share
/usr/share/doc/geos-doc-2.1.4/doc/example.o
W: geos-doc hidden-file-or-dir /usr/share/doc/geos-doc-2.1.4/doc/.deps
W: geos-doc hidden-file-or-dir /usr/share/doc/geos-doc-2.1.4/doc/.deps
W: geos-doc hidden-file-or-dir /usr/share/doc/geos-doc-2.1.4/doc/.libs
W: geos-doc hidden-file-or-dir /usr/share/doc/geos-doc-2.1.4/doc/.libs

rpmlint is right on these. These are temporary files which must not be shipped.


2. I'd recommend to merge the *-doc package into the *-devel package.


3. geos-devel contains /usr/bin/XMLTester

IMO, this application's name is unfortunate and could (should?) be considered to
be too general for a devel-package. I'd recommend either not shipping this
binary or to rename it, rsp. to install somewhere else but to /usr/bin.

I know too little about geos rsp. XMLTester to judge if this is possible/feasible.

4. The geos-2.1.4-config.patch seems incomplete:
# geos-config --cflags
-I/usr/include

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.