[Bug 169801] Review Request: perl-Net-IP-CMatch - Efficiently match IP addresses against IP ranges with C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-IP-CMatch - Efficiently match IP addresses against IP ranges with C


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169801


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-18 13:17 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 (i386) and in mock for rawhide (i386)
- BR's mostly OK
- no libraries, locales, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no file permission issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets

Needswork:

- package should own directory %{perl_vendorarch}/Net since it's not owned by
  any of its dependencies

Nitpick:

- perl is part of the minimal buildroot and hence the explicit BR: perl is not
needed

Suggestions:

- http://search.cpan.org/dist/Net-IP-CMatch/ would be a more stable URL to
  use since it won't change if there is a new upstream version and the
  package is updated

- using %{version} instead of hardcoding the version number in the Source0 URL
  would mean less to change and less chance of errors if there is a new
  upstream version and the package is updated

- the compiler optimization flags setting could be simplified to:

  %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
  make %{?_smp_mflags}

- the "Changes" file could be included as %doc


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.