[Bug 166551] Review Request: synce-trayicon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  synce-trayicon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166551





------- Additional Comments From paul at city-fan.org  2005-10-19 03:49 EST -------
(In reply to comment #3)
> %makeinstall is a hack which was needed back when autotools didn't have a sane 
> way of doing staged installs.  Nowadays the official documented way to do that 
> is to use DESTDIR.  It's not _that_ important and some packages will only 
> install properly with one of the above, but when given a choice, DESTDIR is 
> often seen as the "cleaner" way.  And both occasionally reveal different 
> upstream autotools usage bugs. 

Using DESTDIR is cleaner because the Makefile doesn't see the path of the
buildroot prepended to the "libdir", "bindir" etc. variables, unlike with
%makeinstall. Some badly-written Makefiles might write the values of these
variables into configuration files or even the target binary itself, which would
then not work properly when installed on a real system, outside the buildroot.

e.g.
Using DESTDIR, you have:
bindir=/usr/bin
DESTDIR=/path/to/buildroot
binaries installed to /path/to/buildroot/usr/bin (OK)
anything using $(bindir) in the Makefile sees the "correct" value

Using %makeinstall, you have:
bindir=/path/to/buildroot/usr/bin
binaries installed to /path/to/buildroot/usr/bin (OK)
anything using $(bindir) in the Makefile sees the "wrong" value


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.