[Bug 170511] Review Request: perl-Cflow - find flows in flow files
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 19 14:25:34 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Cflow - find flows in flow files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170511
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-10-19 10:25 EST -------
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions problems
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets
- package gives impression of running OK (flowdumper -h works as expected)
Nitpick:
- please capitalize the first letter of Summary:
- BR: perl is redundant as perl is a dep of rpm-build
Suggestion:
- package currently fails to build in mock due to Bug 171206
you could work around this for now by adding a BR of zlib-devel
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list