[Bug 171418] Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 22 15:47:08 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171418
ville.skytta at iki.fi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ville.skytta at iki.fi
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From ville.skytta at iki.fi 2005-10-22 11:47 EST -------
Initial comments, not a full review:
- Are you sure about the %description i18n syntax? I thought it'd be
%description -l $lang, not %description($lang). The Italian one has a typo
(two r's in descrription).
- Why StartupNotify=false in desktop entry?
- "s/Comment= /Comment=/" dvdisaster.desktop
- The desktop entry could use an icon, eg. icons/create.png ->
/usr/share/icons/hicolor/24x24/apps/dvdisaster.png
- "GTK" would sound more appropriate than "GNOME" in desktop entry's
categories
- "Application" is not a registered desktop entry category
- gtk2-devel already pulls in atk-devel and pango-devel (at least in FC4)
- Maybe better to specify localedir as %{_datadir}/locale than
%{_prefix}/share/locale
- LOCALEDIR should be defined in "make" at %build time too as it is compiled
in (see dvdisaster.c). Maybe also other dirs, haven't checked.
Maybe ./configure is not doing its job properly? From "make show":
LOCALEDIR = /usr/locale
DOCDIR = /usr/doc
DOCSUBDIR = /usr/doc/dvdisaster-0.64
- Missing BuildRequires: gettext
- The German and Italian man pages should be marked as %lang(de) and
%lang(it). Ditto the other German and Italian documentation.
- Buildroot remains in installed files, only man pages though
(install fedora-rpmdevtools and add this to your ~/.rpmmacros to reproduce):
%__arch_install_post /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/check-buildroot
/var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/man/it/man1/dvdisaster.1:.IR /var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/doc/dvdisaster-0.64/en
/var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/man/man1/dvdisaster.1:.IR /var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/doc/dvdisaster-0.64/en
/var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/man/de/man1/dvdisaster.1:.IR /var/tmp/dvdisaster-0.64-1-buildroot-scop/usr/share/doc/dvdisaster-0.64/de
Found '/var/tmp/dvdisaster-0.64-1-buildroot-scop' in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.95477 (%install)
- I wonder why the icons are installed as %doc
in /usr/share/doc/dvdisaster-0.64 ?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list