[Bug 171418] Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171418





------- Additional Comments From dmitry at butskoy.name  2005-10-22 15:20 EST -------
> Are you sure about the %description i18n syntax?
Not sure. :) I've tried to guess correct syntax, believing that either rpmbuild
or rpmlint will tell me if i've not guessed... Both say nothing about it. :(

> Why StartupNotify=false in desktop entry?
Just take it from the wiki/PackagingGuidelines example. AFAIK dvdisaster is not
so much closely integrated with Gnome or KDE to support startup-notification
features.

> The desktop entry could use an icon, eg. icons/create.png
Add this one, actually placed as /usr/share/pixmaps/dvdisaster.png

> "Application" is not a registered desktop entry category  
  cd /usr/share/applications
  grep 'Categories.*Application' * 
it gives 93 matches on my FC3 box...

As I make this package for Fedora (not for general use), if Fedora for some
reason does not follow standards, then I should believe Fedora.

> Maybe better to specify localedir as %{_datadir}/locale than  
> %{_prefix}/share/locale
"share/locale" is hardcoded in /usr/lib/rpm/find-debuginfo.sh, therefore I've
chosen such variant.

Other things are done.

New SPEC: http://dmitry.butskoy.name/dvdisaster/dvdisaster.spec
New SRPM: http://dmitry.butskoy.name/dvdisaster/dvdisaster-0.64-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.