[Bug 170534] Review Request: perl-Net-Patricia - Patricia Trie perl module for fast IP address lookups
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 24 12:49:54 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Net-Patricia - Patricia Trie perl module for fast IP address lookups
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170534
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-10-24 08:49 EST -------
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in FC4 (i386) and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- docs don't affect runtime
- no large docs
- no desktop entry needed
- no scriptlets
Nitpick:
- fiddling with LD_RUN_PATH hasn't been necessary since FC2 - see
http://koti.welho.com/vskytta/packagers-handbook/packagers-handbook.html#guidelines-perl-linkerflags
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list