[Bug 169743] Review Request: libibverbs - InfiniBand user access library
bugzilla at redhat.com
bugzilla at redhat.com
Tue Oct 25 02:30:42 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libibverbs - InfiniBand user access library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169743
ed at eh3.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |ed at eh3.com
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From ed at eh3.com 2005-10-24 22:30 EST -------
nits:
- please change Source from:
http://openib.org/downloads/%{name}-%{ver}.tar.gz
to:
http://openib.org/downloads/libibverbs-1.0-rc3.tar.gz
since the former is an invalid URL
good:
+ license is OK and included per license terms (good!)
+ source matches upstream
+ builds in mock on FC-4
+ spec is clean/readable
+ code not content
+ proper use of devel
+ *.la are deleted and ldconfig OK
+ no complaints or warnings from rpmlint
Unfortunately, I don't have any IB hardware to test it on (we use
Myrinet and/or ethernet for our clusters).
But regardless, this appears to be a good, clean first package.
Congrats!
APPROVED.
And yes, I volunteer to sponsor you so please feel free to contact
me if you have any questions, etc.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list