[Bug 169716] Review Request: fortune-firefly

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fortune-firefly


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169716


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-10-05 18:56 EST -------
I caught two minor issues first:

- The changelog referred to 1.8.1, but the latest version is 1.8. I'm thinking
Michael meant to put "1.8-1". Everytime you increment version (or release) you
should put an entry in the changelog explaining why. I added an entry for 1.8-2,
otherwise, rpmlint would have complained.

- Instead of /usr/sbin, use %{_sbindir}. It's the same thing, but it keeps the
rpm spec cleaner and ensures consistent macro use. I changed it out in the two
places it was used in the spec file.

Review (with above changes made):

Good:

- rpmlint checks return: nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- content enhances user experience
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

With those changes, this package is APPROVED. Thanks for packaging this up, I'm
a huge Firefly fan.

I will sponsor you, so go ahead and do your paperwork.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.