[Bug 166203] Review Request: perl-Maypole : MVC web application framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Maypole : MVC web application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166203





------- Additional Comments From rc040203 at freenet.de  2005-10-07 09:43 EST -------
Maypole-2.10/lib/Maypole/Session.pm
@@ -35,7 +35,7 @@
 sub generate_unique_id {
     my $length = shift || 32;
     my $id = substr(Digest::MD5::md5_hex(Digest::MD5::md5_hex(time(). {}.
rand(). $$)), 0, $length);
-    return;
+    return $id;
 }


(In reply to comment #4)
> (In reply to comment #3)

> > I think the sessionfix patch and the inclusion of Maypole-Plugin-Session are
> > necessary, because I don't want to deviate from upstream.

> There is, however, a bug in Maypole::Session:
>   http://rt.cpan.org/NoAuth/Bug.html?id=14124
 
> As noted, this is fixed in the SVN trunk. The sessionfix patch does make this
> bug irrelevant, but I'm still not sure why Maypole-Plugin-Session is included. 
> I'll need more convincing on that.
Seconded. I think, the sessionfix should be removed and be replaced by
Maypole/Session.pm from SVN, which effectively is a one-liner diff:

Maypole-2.10/lib/Maypole/Session.pm
@@ -35,7 +35,7 @@
 sub generate_unique_id {
     my $length = shift || 32;
     my $id = substr(Digest::MD5::md5_hex(Digest::MD5::md5_hex(time(). {}.
rand(). $$)), 0, $length);
-    return;
+    return $id;
 }

AFAIU, this also renders the Maypole-Plugin-Session module superfluous, rsp.
enables you to package it separately ...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.