[Bug 170165] Review Request: nautilus-sendto

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nautilus-sendto


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170165





------- Additional Comments From bdpepple at ameritech.net  2005-10-07 20:47 EST -------
Once the bad item is fixed:  PUBLISH +1

MD5Sums:
2b8bff75d6cda7b1648d59dde6e4e3b2  nautilus-sendto-0.4.tar.bz2

Good:
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* No deprecated fields used
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Rpmlint does not find problems
* Package installs and uninstalls cleanly on FC4.
* Software runs fine.  Note: Didn't test bluetooth plugin.

Bad:
* Should the evolution plugin be in a seperate package?  Without
  one of the plugins install, nautilus-sendto just crashes when
  called.  Personally, I would add the evolution plugin to the 
  main package, and leave the gaim & bluetooth seperate.  Or you
  could have the nautilus-sendto package be dependent on something
  like nautilus-sendto-plugins which would be provided by the
  installed plugins.

Minor:
* Group tag should probably be System Environment/Shells, this is what
  the other nautilus plugins (search, image resize) in Extras are.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.