[Bug 168580] Review Request: perl-Crypt-DES

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Crypt-DES


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168580


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-10 06:17 EST -------
Review:

- rpmlint nearly clean; see below
- package and spec naming OK
- package meets guidelines
- license looks BSD-ish to me but see below
- license text included in package
- spec file written in English and is legible
- sources match upstream
- package builds OK in FC4 and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no unowned directories or file permission problems
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- no large docs, docs don't affect runtime
- code, not content
- no desktop entry needed
- no scriptlets

Queries:

- I don't think the rpath-fixing editing out of LD_RUN_PATH from the Makefile
  is necessary for Fedora Extras packages (not since FC2 according to
  http://koti.welho.com/vskytta/packagers-handbook/packagers-handbook.html)

- Why the manual dep on perl(Crypt::CBC)? I can understand the BuildRequire
  for this (needed for the test suite), but not the runtime dep.

- License looks BSD-ish to me too, but I'm not a licensing expert and would
  appreciate it if someone more knowledgable on this gave it a look. You can
  shut rpmlint up by changing the License: tag to "BSD-style".

- Why not use:
  %{perl_vendorarch}/auto/Crypt/
  rather than:
  %{perl_vendorarch}/auto/
  in the files list?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.