[Bug 167943] Review Request: sblim-cmpi-base

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sblim-cmpi-base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167943


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com




------- Additional Comments From tcallawa at redhat.com  2005-10-10 17:17 EST -------
No one has reviewed this yet... but here is some information to help you out:

If you're a new contributor (if this is your first package) you need to follow
the steps listed here:
http://fedoraproject.org/wiki/Extras/Contributors

I took a very quick glance at your spec file, and the following issues need to
be corrected:

- Use the Fedora standard BuildRoot as defined in PackagingGuidelines
- Don't do this: Release: 1%{?tog_pegasus:.tog_pegasus} You shouldn't be putting
random text in the release field, conditionalized or not. The only thing that
can go there are specific pre/post release cases (e.g. openssl 0.9.6a, mozilla
1.8beta1) or the dist tag (%{?dist}). All of these are documented in
PackagingGuidelines
- Source0: http://prdownloads. ... thats not a valid url (wget will choke on
it). Change it to http://download.sourceforge.net/...
- Unconditionalize your requires. You either need em or you don't. When in
doubt, default to including them and making the package as fully featured as
possible. Same goes for the %configure conditionalizing.
- The devel and test packages need Requires: %{name} = %{version}-%{release},
not just %{version}.
- %setup -n %{name}-%{version} is the default, you can just say %setup
- don't conditionalize the removal of $RPM_BUILD_ROOT, just nuke it. We're
always setting it in the spec file, so we know it will never ever ever be /
without checking.
- don't strip the libraries, the rpm build process does this for us, and saves
it in the -debuginfo package, so we can use those symbols for debugging later.
- you don't need to conditionalize the %postun ldconfig call, because it never
hurts to run ldconfig. :) Also, in the unlikely case that the new package
doesn't install but the old one goes out, we still want the system state to
reflect that.
- Don't use %{version}-%{release} in changelog, this will only be right once.
Hardcode it.

If you have any questions, let me know. Post a package that has the above items
resolved, and I'll do a formal review. :)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.