[Bug 170506] Review Request: grepmail

[Michael A. Peters]

(not to bugzilla)

On Wed, 2005-10-12 at 12:15 -0400, bugzilla at redhat.com wrote:
> Please do not reply directly to this email. All additional
> comments should be made in the comments box of this bug report.
> 
> Summary: Review Request: grepmail
> 
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170506
> 
> 
> 
> 
> 
> ------- Additional Comments From rc040203 at freenet.de  2005-10-12 12:15 EST -------
> Just a comment:
> %{_bindir}/find ...
> 
> is pretty much free of sense. %_bindir is a user input parameter to rpmbuild,
> not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants).
> 
> Try rpmbuild --define '_bindir /tmp' to experience the difference.
> 
> I strongly recommend to use find or /usr/bin/find instead.

I second this - prefering find to /usr/bin/find

imho when a system utility is used to build/install - unless the path is
needed (ie /usr/sbin/foo) then it should use whatever comes first in the
path of the rpm builder (or rpm's defined path)