[Bug 169247] Review request: rt3 - Request tracker 3

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: rt3 - Request tracker 3


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169247


chris at chrisgrau.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |chris at chrisgrau.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From chris at chrisgrau.com  2005-10-12 17:38 EST -------
$ rpmlint rt3-3.4.4-4.fc4.src.rpm
W: rt3 strange-permission rt3-filter-requires.sh 0755
W: rt3 strange-permission rt3-filter-provides.sh 0755

These are strange to me.  I would guess those are the proper permissions for
such files.  I'm assuming this is ignorable.

E: rt3 configure-without-libdir-spec

This can be ignored.  The configure script for rt3 doesn't take a libdir argument.

$ rpmlint rt3-3.4.4-4.fc4.noarch.rpm | sort
E: rt3 dir-or-file-in-usr-local /usr/local/etc/rt3
E: rt3 dir-or-file-in-usr-local /usr/local/lib/rt3
E: rt3 dir-or-file-in-usr-local /usr/local/lib/rt3/html
E: rt3 dir-or-file-in-usr-local /usr/local/lib/rt3/lib
E: rt3 dir-or-file-in-usr-local /usr/local/lib/rt3/po

Why are directories being %ghosted in /usr/local?  I see these directories being
configured in the Fedora layout, and I'm inferring from it that these are used
for user-generated content.  If that's the case, I don't really see a problem
with it, but it is odd to see an package owning anything in /usr/local.

E: rt3 non-readable /etc/rt3/RT_Config.pm 0640
E: rt3 non-readable /etc/rt3/RT_SiteConfig.pm 0640
E: rt3 non-standard-dir-perm /var/lib/rt3/mason_data 0770
E: rt3 non-standard-dir-perm /var/lib/rt3/mason_data/cache 0770
E: rt3 non-standard-dir-perm /var/lib/rt3/mason_data/etc 0770
E: rt3 non-standard-dir-perm /var/lib/rt3/mason_data/obj 0770
E: rt3 non-standard-dir-perm /var/lib/rt3/session_data 0770
E: rt3 non-standard-gid /var/lib/rt3/mason_data apache
E: rt3 non-standard-gid /var/lib/rt3/mason_data/cache apache
E: rt3 non-standard-gid /var/lib/rt3/mason_data/etc apache
E: rt3 non-standard-gid /var/lib/rt3/mason_data/obj apache
E: rt3 non-standard-gid /var/lib/rt3/session_data apache
E: rt3 non-standard-uid /var/lib/rt3/mason_data apache
E: rt3 non-standard-uid /var/lib/rt3/mason_data/cache apache
E: rt3 non-standard-uid /var/lib/rt3/mason_data/etc apache
E: rt3 non-standard-uid /var/lib/rt3/mason_data/obj apache
E: rt3 non-standard-uid /var/lib/rt3/session_data apache

These are all ignorable.  They're set that way on purpose for security reasons.

W: rt3 dangerous-command-in-%postun userdel

I'll leave this one alone.  The package creates the user in %pre, it's only
right that the user is removed when no longer needed, I suppose.

W: rt3 non-conffile-in-etc /etc/rt3/acl.Informix
W: rt3 non-conffile-in-etc /etc/rt3/acl.mysql
W: rt3 non-conffile-in-etc /etc/rt3/acl.Oracle
W: rt3 non-conffile-in-etc /etc/rt3/acl.Pg
W: rt3 non-conffile-in-etc /etc/rt3/acl.Sybase
W: rt3 non-conffile-in-etc /etc/rt3/initialdata
W: rt3 non-conffile-in-etc /etc/rt3/schema.Informix
W: rt3 non-conffile-in-etc /etc/rt3/schema.mysql
W: rt3 non-conffile-in-etc /etc/rt3/schema.Oracle
W: rt3 non-conffile-in-etc /etc/rt3/schema.Pg
W: rt3 non-conffile-in-etc /etc/rt3/schema.SQLite
W: rt3 non-conffile-in-etc /etc/rt3/schema.Sybase

True, these aren't configuration files, but rather initialization files.  Maybe
a better place for them would be /usr/share/rt3?

An explicit requires is needed for perl(HTML::Mason).

I don't like that /usr/sbin/webmux.pl has mode +x, since it's meant to be
sourced and doesn't actually do anything when run.  I think it would be better
somewhere like /usr/lib/rt3, but I don't know how much that change would affect
the RT install.

Would /var/lib/rt3 be better as /var/cache/rt3?

I ran into SELinux issues when starting httpd.  Maybe a README.SELinux
mentioning that /var/lib/rt3 and its subdirectories need the proper SELinux
settings.

It took some tinkering to get running (installing the proper DBD and
initializing the database).  The existing README section on initializing the
database isn't appropriate for an RPM-based install.  For its target audience, I
don't think it's very difficult.  Maybe just add README.Fedora to point users to
/etc/rt3.

I didn't know what to do with RT once I got it running and didn't have much luck
getting rt-setup-database to work, but I'm going to chalk that up to user error.
 I did get a login page with RT installed on my local httpd server, so I'm going
to go ahead and say the package does work as intended.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.