[Bug 170506] Review Request: grepmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grepmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170506





------- Additional Comments From paul at city-fan.org  2005-10-13 09:05 EST -------
(In reply to comment #4)
> Just a comment:
> %{_bindir}/find ...
> 
> is pretty much free of sense. %_bindir is a user input parameter to rpmbuild,
> not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants).

Is this distinction described somewhere?

> Try rpmbuild --define '_bindir /tmp' to experience the difference.

Both %_bindir and %__chmod are defined in /usr/lib/rpm/macros and can be
redefined in the same way on the command-line. I always believed that the macros
were there to provide distribution-portability rather than being "user input
parameters".

> I strongly recommend to use find or /usr/bin/find instead.

I see what you're getting at here, in that redefining %_bindir so that the
binaries are installed in a different place breaks the build when it expects to
find things in the same place. I'd rather not use plain "find" because that
breaks reproducability of builds if someone has a different/broken version of
find earlier in their PATH, so /usr/bin/find looks better to me. But it does
make the assumption that %_bindir was set to /usr/bin when the distribution's
"find" package was built, which may not be true on all distributions (not that
any of this matters for Fedora Extras). Having said that, similar assumptions
are made for programs in /bin, /sbin etc., which don't have corresponding macros
defined for them. Ideally I suppose it would be better if there were additional
macros defined such as %__find etc., but it's a bit late for that now.

I'll probably change it to /usr/bin/find


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.