[Bug 170303] Review Request: google-perftools: Very fast malloc & performance analysis tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: google-perftools: Very fast malloc & performance analysis tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170303





------- Additional Comments From dmitry at butskoy.name  2005-10-13 12:14 EST -------
Remarks and nitpicks:
- Group "Applications/System" seems does not meet the purpose of this soft, IMHO
it should be "Development/Tools" or similar.
- The stuff with explicitly "%{_docdir}" etc. looks not very well. I would
suggest to remove all the docs in their default path (after "make install"), and
then to specify it explicitly as "%doc something" etc. in the %files section.
- It would be better to move all html documentation and related files into a
separate subdirectory (for example, "mv doc html" in "%install" section, then
specify "%doc html" in "%files" ...)
- A section "%check" must be used, as "make check" possibility is present.

- There is no license text as a separate file.
- There are two names "google-perftools" and "goog-perftools" (the last is used
in URLs). Why "goog" has appeared? I guess it is some trademark issues here.
Therefore the package probably should be renamed...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.