[Bug 169789] Review Request: tiobench

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tiobench


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169789


fedora at leemhuis.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.leemhuis.info/fil|http://www.leemhuis.info/fil
                   |es/fedorarpms/SRPMS.fdr/tiob|es/fedorarpms/SRPMS.fdr/tiob
                   |ench-0.3.3-1.src.rpm        |ench-0.3.3-2.src.rpm




------- Additional Comments From fedora at leemhuis.info  2005-10-14 11:16 EST -------
Dmitry, thx for reviewing

(In reply to comment #3)
> Remarks and nitpicks:
> - As something is compiled, use %{?dist} in release (to separate builds for
> different distros).
dist is still optional in fedora-extras. But I added it, I just forgot it. :)

> - Mixed macro style. 
Changed

> - Additional manuals (Source1,2)[...]let rpm compress them later its own way.
Changed, but in a different way

> - If the additional manuals are present somewhere separately, it is better to
> specify full urls for them.
Sure -- I did find a trustworthy URL (besides the debian package -- and
including that as source is IMHO overkill)

Spec Name or Url:
http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/tiobench.spec

SRPM Name or Url:
http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/tiobench-0.3.3-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.