[Bug 170296] Review Request: qalculate-kde - qt gui frontends to qalculate

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qalculate-kde - qt gui frontends to qalculate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170296


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-14 11:39 EST -------
Review:

- rpmlint nearly clean - see below
- package and spec file naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's OK
- %find_lang used to handle locale data properly
- HTML documentation also handled properly
- no libraries, pkgconfigs or subpackages to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- docs not excessively large
- docs don't affect runtime, except for online help not working if --excludedocs
is used
- desktop file installed properly
- package appears to function correctly
- no scriptlets
- all previous issues addressed

Notes:

- rpmlint output:
  W: qalculate-kde dangling-symlink /usr/share/doc/HTML/en/qalculate_kde/common
/usr/share/doc/HTML/en/common
  W: qalculate-kde symlink-should-be-relative
/usr/share/doc/HTML/en/qalculate_kde/common /usr/share/doc/HTML/en/common
  this is common with KDE apps and has been OK-ed before:
  http://www.redhat.com/archives/fedora-extras-list/2005-July/msg01495.html

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.