[Bug 169789] Review Request: tiobench

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tiobench


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169789





------- Additional Comments From dmitry at butskoy.name  2005-10-14 10:18 EST -------
Remarks and nitpicks:
- As something is compiled, use %{?dist} in release (to separate builds for
different distros).
- Mixed macro style. As used $RPM_BUILD_ROOT, use $RPM_OPT_FLAGS, not
%{optflags} (or vice versa).
- Additional manuals (Source1,2) are copied directly. It provides correct result
now, but sometime in the future it will be possible that manuails will be
compressed as .bz2, or will not be compressed at all. Therefore it is better to
just uncompress these files and let rpm compress them later its own way.
- If the additional manuals are present somewhere separately, it is better to
specify full urls for them.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.