[Bug 170131] Review Request: php-extras - Additional PHP modules from the standard PHP distribution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-extras - Additional PHP modules from the standard PHP distribution


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170131





------- Additional Comments From dmitry at butskoy.name  2005-10-17 13:31 EST -------
> - The conditionals (_with_*/_without_*) are used in a wrong way since modules
> cannot be enabled or disabled on the rpmbuild command line
Improved, now should work

> - Setting the php extension dir to /var/tmp if the php-config execution to get
> it fails is a bad idea (as it will lead to a really broken package)
> - Same goes for the version ...
Just removed "else" things. If no php-config present, user will be stopped by
"empty Vesrion tag" error.

> Using %{summary} ...
changed to explicit text.

> - Add the sub-package headers (from %package to %description, included) don't
> need to be wrapped in %if/%endif as they will simply be ignored if they don't
> have a matching %files section
If I remove "%if/%endif" wraps, all existing BuildRequires will take effect,
which I prefer to avoid.

> - The CFLAGS export seems unneeded
Just preserve the main php package behaviour here (both php4 and php5 use it).

> - The readline LIBS hack ...
removed, a patch added instead.

> - The %check section is ugly, probably needs cleaning up, ...
Thanks! I've spent two days to find the most compact working variant... :)
> use some explicit comments about what is being done and why
surely, add some comments

> - The per .so file %attr(755,root,root)
removed

SPEC/SRPM updated (the same urls as above).


> Please let me know if you want me to take a stab at it.

Matthias,

I'll be happy if you wanna review this!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.