[Bug 166960] Review Request: Fuse-emulator (and associated libraries)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Fuse-emulator (and associated libraries)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166960





------- Additional Comments From paul at city-fan.org  2005-10-18 08:20 EST -------
Some notes after a quick look at the fuse-emulator package:

The package is still called fuse rather than fuse-emulator

The spec file name is fuse-0.7.0-noroms.spec but should be fuse-emulator.spec

Some optimization of the BuildRequires is possible:
* zlib-devel is required by libxml2-devel and libpng-devel and can be omitted
* glibc-devel is required by gcc and can be omitted 

You have:
Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils
but the %post and %postun scriptlets are empty

What's with the BR: gtk2-devel => 2.8.0; this prevents builds on FC4 and below,
and appears to be unnecessary; the package builds fine on FC4 with gtk2-devel
2.6.10 anyway and the configure script only appears to check for version 2.0.0
or above

The libraries should really have separate review requests rather than being
lumped into one big request like this one

The tarball URL referenced in the ROMS file does not work

Spec file should clearly indicate that the SRPM tarball is modified from
upstream so as to not include the ROMS (maybe rename the tarball
fuse-noroms-0.7.0...)

A quick HOWTO describing how to run some of the examples in the z88dk package
would be nice; I haven't figured it out yet so perhaps it's non-obvious...




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.