[Bug 170384] Review request: perl-DBIx-DBSchema - Database-independent schema objects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-DBIx-DBSchema - Database-independent schema objects


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170384


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-20 07:49 EST -------
Review:

- rpmlint clean ????

- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets

Suggestions:

- Buildreq perl(DBD::Pg) >= 1.32 will need changing to perl-DBD-Pg >= 1.32 for
  rawhide due to Bug 167797, at least until that bug is fixed

- Might http://search.cpan.org/dist/DBIx-DBSchema/ be a better URL than
  http://search.cpan.org/~ivan/DBIx-DBSchema-%{version}/ ?

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.