[Bug 169030] Review Request: Workrave

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Workrave


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169030


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-10-21 13:14 EST -------
Built on FC4, i386:

* Need to use %find_lang macro, as per the PackagingGuidelines on the wiki

* rpmlint output: 

W: workrave non-conffile-in-etc /etc/sound/events/workrave.soundlist
W: workrave non-standard-dir-in-usr libexec
W: workrave file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/eu/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/he/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/no/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/eo/LC_MESSAGES/workrave.po
W: workrave file-not-in-%lang /usr/share/locale/lt/LC_MESSAGES/workrave.po
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/src/System.cc
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/HeadInfo.cc
E: workrave-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/HeadInfo.cc
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/include/System.hh
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/src/TimerBoxControl.cc
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxView.hh
E: workrave-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxView.hhE:
workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/include/TimeBarInterface.hh
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/MicroBreakWindow.cc
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/TimerBoxGtkView.hh
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxControl.hh
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/MicroBreakWindow.hh
E: workrave-debuginfo script-without-shellbang
/usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/TimerBoxGtkView.cc

%find_lang with fix the lang ones. For the debug info chmod -x *.cc and *.hh
files in %prep or something

conffile and libexec dir can probably be ignored, at least based on precedent of
other Gnome apps and applets

* need a .desktop file for workrave executable, and install it with
desktop-file-install

* configure did check for XML::Parer, if this is important perl-libxml-enno is
needed as a BuildRequires

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.