[Bug 167889] Review Request: polyxmass-data - Contains configuration files describing polymer chemistry

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polyxmass-data - Contains configuration files describing polymer chemistry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167889


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-10-22 18:58 EST -------
This data is necessary for polyxmass to be useful, so it is acceptable data

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

needs work:
- does not appear to own or require /usr/share/polyxmass
- rpmlint:
W: polyxmass-data non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat
W: polyxmass-data non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic

and a while lot of zero length .ogg files. Are the oggs necessary? The conffile
can probably be ignored, it's really a config file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.