[Bug 167888] Review Request: polyxmass-common - Contains all textual/graphical data required for polyxmass

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polyxmass-common - Contains all textual/graphical data required for polyxmass


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167888


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-10-23 00:32 EST -------
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no locales
- not relocatable
- permissions ok
- %clean ok
- macro use consistent
- acceptable content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- rpmlint:
W: polyxmass-common no-version-in-last-changelog
W: polyxmass-common non-conffile-in-etc /etc/polyxmass/chempad.conf
W: polyxmass-common non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-common-polchem-defs-atom-defs-dic
W: polyxmass-common non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-common-polchem-defs-cat
W: polyxmass-common non-conffile-in-etc
/etc/polyxmass/atom-defs/polyxmass-common-atom-defs-cat

all of which are minor and can probably be ignored.


The description is hardly different from polyxmass-data. Could be more clear as
to the difference. Also, both common and data seem to own
/usr/share/polyxmass/pol-seqs and /etc/polyxmass/polchem-defs. Any reason not to
combine the two into one package, or two packages from one spec?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.