[Bug 170995] Review Request: System Control Center (system-config-control)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: System Control Center (system-config-control)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170995


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-10-24 22:19 EST -------
Review: 

Good:

- rpmlint checks return:
W: system-config-control no-documentation

( safe to ignore )

E: system-config-control script-without-shellbang
/usr/share/system-config-control/system-config-control.glade
E: system-config-control script-without-shellbang
/usr/share/system-config-control/system-config-control.gladep

( false positives, glade files are not scripts ) 

W: system-config-control symlink-should-be-relative
/usr/share/firstboot/modules/system-config-control.py
/usr/share/system-config-control/system-config-control.py

( ok by me. )

E: system-config-control script-without-shellbang
/usr/share/system-config-control/system-config-control.py

( Doesn't seem to affect runtime, so I'm ok )

W: system-config-control no-dependency-on usermode-consoleonly

( safe to ignore )

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent (one minor exception)
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file ok, handled properly

Minor items:

- In %clean, please use %{name} instead of %name for macro consistency.
- There is no need for the Requires(post) and Requires(postun). This is actually
my fault, since I accidentally put them in there when I was helping with the
pre-review cleanup. Sorry bout that.
- Don't use prdownloads.sourceforge.net, use download.sourceforge.net. 

You might also want to consider using the %{?dist} tag at the end of the
release. This will help you use one spec for all branches of Fedora Core,
without artificially inflating the release number. See:
http://fedoraproject.org/wiki/DistTag

You also should consider including some documentation in the upstream source
(and in the package as %doc), especially, a copy of the GPL text in LICENSE.

Otherwise, this package looks good. Approved, as long as you fix those three
minor items before commit.

I will also sponsor you, please do your paperwork. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.