[Bug 171915] Review Request: texmaker - LaTeX editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: texmaker - LaTeX editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171915


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: texmaker -  |Review Request: texmaker -
                   |LaTeX editor                |LaTeX editor
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-10-27 17:13 EST -------
Needs work:
* BuildRequires: desktop-file-utils is missing
* BuildRequires: gcc-c++ should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Make sure no line in %description is more than 80 chars long
* latexhelp.html and usermanual.html packaged twice, remove them from %doc
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)
* Scriptlets: missing update-desktop-database
  (wiki: ScriptletSnippets)
* Scriptlets: missing "gtk-update-icon-cache" in %post and %postun 
  (wiki: ScriptletSnippets)
* Requires: desktop-file-utils is useless
* The manual install of the binary is not necessary (it is copied during "make
  install")
* Don't copy the icon to _datadir/pixmaps, it's useless (the menu icon will be
  found in _datadir/icons/hicolor)
* Don't delete original desktop files, it comes from your source dir
* Don't package the INSTALL file, it's useless since we're using RPM
* %dir %{_datadir}/texmaker and %{_datadir}/texmaker/* can be combined into
  %{_datadir}/texmaker/
* TerminalOptions in desktop file is depreciated, please remove it in your patch

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.