[Bug 166209] Review Request: apcupsd - APC UPS Power Control Daemon for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: apcupsd - APC UPS Power Control Daemon for Linux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166209





------- Additional Comments From jpmahowald at gmail.com  2005-10-29 18:24 EST -------
Works now without %{?_smp_mflags}, so please remove them.

rpmlint says:
W: apcupsd no-reload-entry /etc/rc.d/init.d/apcupsd
W: apcupsd service-default-enabled /etc/rc.d/init.d/apcupsd
W: apcupsd-cgi no-documentation
W: apcupsd-cgi non-conffile-in-etc /etc/apcupsd/apcupsd.css

Change the init script so it doesn't start by default. And mark that css file as
a config file if it indeed is one.

Need to Require chkconfig

Source0 URL doesn't exist. You probably want
http://download.sourceforge.net/apcupsd/apcupsd-3.10.18.tar.gz, which does match.

The following looks good
- package meets packaging guidelines
- spec file legible
- package compiles on FC4 i386
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.