[Bug 168705] Review Request: newscache - Free cache server for USENET News

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: newscache - Free cache server for USENET News


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168705





------- Additional Comments From dmitry at butskoy.name  2005-10-31 08:18 EST -------
> Missing many BuildRequires: libtool, automake, autoconf, texinfo, pam-devel
libtool already implies automake/autoconf, other will be added.

> Release is for the build of the rpm, not the upstream release version. So
> Version is 1.2rc6 and Release is 1 (first build).
See
http://fedoraproject.org/wiki/PackageNamingGuidelines#head-63c1c3d339e145e51777b81c9f9adc8120aa762f
"rc" should go to release field. And rpmlint requires such a way too...

> And I don't see the point of defining a macro for %{name}-%{release}
Hmmm... Where you have found it?.. :)
I guess it is about %{srcnamever}? "NewsCache" is a historical name. Now most of
things in the package are low-registered, but the tarball is still such...

> socket++ is not strictly a part of newscache. I recommend it be packaged
seperately.
I've already mention it in the spec file comments:
 # socket++ is a library from the same site as NewScache is.
 # While it is used by newscache only, there is no reason
 # to ship it separately.
I would like to not mess up FE by superfluous packages. Currently socket++ is
used by newscache only, distributed from the same site as newscache, and I
believe (with full respect for socket++ developers) that it hardly will be used
somewhere else in the near future.

Certainly if it will be needed, I'll exclude this library as a separate package.

> E: newscache executable-marked-as-config-file /etc/cron.daily/newscache
I just follow Fedora Core here: see for example "yum.spec" or "tmpwatch.spec".
Both "chmod +x" and then marked as "%config(noreplace)" ...
> E: newscache executable-marked-as-config-file /etc/rc.d/init.d/newscache
Similar (see "httpd.spec" for example)
It means that rpmlint and FC ways are differ. I would prefer FC now :)

> > Summary: Free cache server for USENET News
> Can there be any non-free cache server in Fedora?
Yep! In the additional repositories, or from the owner's sites (as java, flash) etc.
This summary has come from upstream. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.