[Bug 166023] Review Request: BibTool. Tool for manipulating BibTeX data bases
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 2 01:55:09 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: BibTool. Tool for manipulating BibTeX data bases
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166023
ed at eh3.com changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| http://www.gerd- |http://www.gerd-
|neugebauer.de/software/TeX/B|neugebauer.de/software/TeX/B
|ibTool.en.html |ibTool.en.html
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |ed at eh3.com
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From ed at eh3.com 2005-09-01 21:54 EST -------
Hi Patrice, heres a quick review:
small things easily fixed:
- rpmlint reports:
E: BibTool wrong-script-interpreter
/usr/share/doc/BibTool-2.48/Perl/bibtool.pl "/usr/local/bin/perl"
E: BibTool wrong-script-interpreter
/usr/share/doc/BibTool-2.48/Tcl/bibtool.tcl "/usr/local/bin/tclsh"
- specfile uses a mix of tabs and spaces
good:
- source matches upstream
- naming is OK
- license looks OK and is in %doc
- builds in mock on FC-4 and runs without segfaults
- specfile is very simple and legible
- dir ownership is OK
- code not content
- no *.la or any shared libs
- very simple and clean package
While the two rpmlint warnings are annoying, I don't think that they're
blockers. It would be nice if you (please!) created a patch so that the
two rpmlint errors are fixed -- and thus the two examples would work
automatically (someone could just copy them into their home dir and add
execute permissions to use them). But, its something you can do after
importing the package into CVS.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list