[Bug 165689] Review Request: SquidGuard: filter, redirector and access controller plugin for squid

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SquidGuard: filter, redirector and access controller plugin for squid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165689


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: Filter,     |Review Request: SquidGuard:
                   |redirector and access       |filter, redirector and
                   |controller plugin for squid |access controller plugin for
                   |                            |squid
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-09-04 12:27 EST -------
* the logrotate file contains "olddir /var/log/old/squid". This is not standard,
please remove it.
* this file should also be tagged as %config(noreplace) in case the user makes
changes.
* in the package's description, there are "**)" symbols. What does that mean ?
Maybe a bad copy/paste ?
* Source3 is guard-distrib.tar.gz: where does it come from ? It is copied to
samples/, but not included in the rpm (not in the %files section). If it is not
useful, please remove it.
* SMP flags are not used. If it does not build with it, please write a small
comment above the make command
* the checks "RPM_BUILD_ROOT != /" are useless in %install and %clean, please
remove them.
* use install -p to preserve timestamps
* the "mkdir -p $RPM_BUILD_ROOT%{_dbhomedir}" line in %install is useless, the
dir was created with install above
* "%dir %{_dbhomedir}" and "%{_dbhomedir}/*" can be summed up in simply
"%{_dbhomedir}/"
* don't create $RPM_BUILD_ROOT%{_datadir}/%{name} in %install, since there are
no files in it.
* Source 2 is not available anymore. In the same directory, there is a
blacklists.tar.gz file which seems to be the same as the versionned one. Maybe
you could use that.
* BuildRoot: should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* The package should contain the text of the license. Please include the COPYING
file.
* The default squidGuard.conf file does not work since your blacklists are in
%dbhomedir/blacklists and the file refers to %dbhomedir/dest. It would be nice
to make it work by default, and a simple "s,dest/adult/,blacklists/porn/,g" on
the file should fix it. There is still the problem of the invalid redirection,
but I don't think we can do much about that, can we ?

* a possible improvement would be to add a script to update the blacklists. Many
are available on the web, you could for example try this one:
http://cuda.port-aransas.k12.tx.us/squid-getlist.html or base yours on it. This
is not a blocker, but could be a nice improvement if you are interested in
squidGuard.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.