[Bug 165689] Review Request: SquidGuard: filter, redirector and access controller plugin for squid

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 5 15:52:02 UTC 2005

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SquidGuard: filter, redirector and access controller plugin for squid


------- Additional Comments From oliver at linux-kernel.at  2005-09-05 11:51 EST -------
(In reply to comment #3)
> > Shall I also include the GPL file from the tarball?
> Discussion is going on on fedora-maintainers about this. Red Hat Legal Dpt.
> suggest to always ship the full license text, but on the other hand it is
> ridiculous to ship 5000 copies of the GPL...
> For the moment, COPYING is enough, you can always add it later when SquidGuard
> is in CVS.

I also think, it better to not included it, it really makes no sense to included
the GPL everywhere...

> > I would have to install the guard.cgi and guard.conf into some place and
> > create an Apache config. It could also be possible, that the admin has no 
> > webserver on the proxy-machine and want's to install the cgi on another 
> > server.
> Exactly. It's nice to customize the default config to have it Just Work(tm), but
> there are limits...


> > Added this and slightly modified it (paths). I also added a var called 
> > ENABLED, which is 0 (therfor disabled) by default...
> Good idea, but we should not modify sources from upstream except with patches or
> in the spec file. When I wget' the URL for Source3, I should always have the
> exact same file as the one inside the SRPM. Therefore, please make a patch. (see 
> the 10th "MUST" in http://fedoraproject.org/wiki/PackageReviewGuidelines)

Oh yes... I thought about makin' a patch, but then I was to lazy/busy. But I did
that now and uploaded the new spec && srpm.

Thanks for your comments!

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the fedora-extras-list mailing list