[Bug 167563] Review Request: frobtads - Interpreter for the Text Adventure Development System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frobtads - Interpreter for the Text Adventure Development System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167563


michel.salim at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michel.salim at gmail.com




------- Additional Comments From michel.salim at gmail.com  2005-09-05 16:28 EST -------
Going to review this more thoroughly once I'm approved for fedorabugs, but a
preliminary pass:

OK:
* rpmlint passes cleanly on .src.rpm and binaries
* package naming follows guideline
* spec file name matches base package
* license matches actual license
* license texts included
* spec in American English, legible
* sources match upstream
* package successfully compiled (tested on i386 so far, will check x86_64 later)
* package owns its directories

  Nitpick: %{_datadir}/frobtads looks cleaner as
  %{_datadir}/frobtads/
  %{_datadir}/frobtads/*

Not sure:
* Package license not OSI-approved - modification only for porting, selling not
allowed
* Saving during the game consistently results in:

                                                                              
*** stack smashing detected ***: frob terminated
                                               Aborted

though the saved game file restores fine

Might be a candidate for Livna instead, anyone has experience with non-standard
licenses? This looks like a combination of SuSE's old Yast license and UW's
license for Pine.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.