[Bug 167377] Review Request: perl-Class-Singleton

bugzilla at redhat.com bugzilla at redhat.com
Wed Sep 7 09:55:41 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Singleton


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167377


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-07 05:55 EST -------
Review:

- package and spec naming OK
- package meets guidelines
- license is Artistic, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 and rawhide (i386)
- no BRs
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- rpmlint not clean:

E: perl-Class-Singleton script-without-shellbang
/usr/lib/perl5/vendor_perl/5.8.6/Class/Singleton.pm
This script does not begins with a shellbang. It will prevent its execution.

This is due to the exec bit being set on Singleton.pm in the upstream tarball,
and this permission is preserved at install-time. It can be fixed by adding
after %setup:

chmod -x Singleton.pm

You can fix that in CVS.

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list