[Bug 165688] Review Request: YAML-Parser-Syck - Perl Wrapper for the YAML Parser Extension: libsyck
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 7 12:37:33 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: YAML-Parser-Syck - Perl Wrapper for the YAML Parser Extension: libsyck
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165688
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From paul at city-fan.org 2005-09-07 08:37 EST -------
Review:
- rpmlint clean
- package naming OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- sources match upstream
- package builds OK in FC4 and in mock for rawhide (i386)
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- spec file should be perl-YAML-Parser-Syck.spec, not YAML-Parser-Syck.spec
- redundant BR: perl
- missing BR: syck-devel
- license is same as perl, i.e. dual GPL/Artistic, not just Artistic
- license text not included
- package is arch-specific so you should be using perl_vendorarch, not
perl_vendorlib
- %clean should unconditionally remove the buildroot
Nitpick:
- what does that %description mean?
"libsyck is a *gift* from a gifted Stiff named 'Why'."
- I suggest manually expanding the %pkgname macro in your spec file to
improve clarity
- http://search.cpan.org/dist/YAML-Parser-Syck/ would be a better URL
- "|| :" after %%check is redundant in Fedora Extras
- compiler optimiztion flags setup could be simplified to:
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
%{__make} %{?_smp_mflags}
- include "Changes" as %doc
- if using macros for commands, e.g. %{__make}, be consistent about it and use
them everywhere
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list