[Bug 167673] Review Request: flow-tools - Tool set for working with NetFlow data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: flow-tools - Tool set for working with NetFlow data


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167673


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-09-07 11:39 EST -------
Review:

Good:

- rpmlint checks return: 
W: flow-tools-devel no-documentation
Safe to ignore.
- meets Packaging, naming guidelines
- license (BSD) OK, text in %doc, matches source
- spec in am. english, legible
- source matches upstream
- compiles on x86 devel
- no missing, unnecessary BuildRequires
- no locales
- post/postun ldconfig ok
- not relocatable
- owns all dirs it creates
- no duplicate files
- permissions ok
- clean ok
- macros consistent
- code, not content
- no need for -docs
- -devel ok
- -devel requires main package n-v-r
- not a gui app
- .la files removed


Nitpick:

- the url for Patch0 (http://stingr.net/2/flow-tools/flow-tools-0.68a.patch) is
a 404. You should either fix the URL or drop it entirely (its not needed).

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.