[Bug 166186] Review Request: perl-Class-DBI-AsForm : Produce HTML form elements for database columns
bugzilla at redhat.com
bugzilla at redhat.com
Thu Sep 8 11:48:23 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-DBI-AsForm : Produce HTML form elements for database columns
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166186
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-09-08 07:48 EST -------
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec written in English and is legible
- sources match upstream
- package builds OK in FC4 and in mock for rawhide (i386)
- BRs OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Nitpick:
- I think the README contains better text for use as %description, rather than
simply repeating %summary:
This module helps to generate HTML forms for creating new database rows
or editing existing rows. It maps column names in a database table to
HTML form elements that fit the schema. Large text fields are turned
into textareas, and fields with a has-a relationship to other
"Class::DBI" tables are turned into select drop-downs populated with
objects from the joined class.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list