[Bug 167820] Review Request: enca - Charset analyzer and discriminator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enca - Charset analyzer and discriminator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167820


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2005-09-08 12:53 EST -------
Will review.  I have a local package of this too, see    
http://cachalot.mine.nu/4/SRPMS/enca-1.7-0.1.src.rpm in case you wish to merge    
some bits.  Initial comments, comparing my and your specfiles, some nitpicks,  
some not:  
    
- Why no support for recode, is everything already covered by iconv?  Could be    
enabled by BuildRequiring recode-devel and removing --without-librecode.    
    
- More docs could be included, for example TODO and ChangeLog*    
    
- No %{?_smp_mflags} in %build    
    
- Test suite not run, could do "make check" in a %check section (after    
%install)    
    
- Static libs shouldn't be shipped without a good reason    
    
- -devel should depend on pkgconfig   
   
- Configuring with --disable-dependency-tracking would result in cleaner build   
output and possibly slight speedup   
   
- libexecdir could be overridden with %{_libdir} for FHS compliance (see my 
package for an example) 
   
- "discriminator" sounds weird to me in the package summary, but that might be 
just my English... what does it mean in this context? 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.