[Bug 167820] Review Request: enca - Charset analyzer and discriminator

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 8 17:25:58 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enca - Charset analyzer and discriminator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167820





------- Additional Comments From dmitry at butskoy.name  2005-09-08 13:25 EST -------
> Why no support for recode
I successfully use enca built with iconv (a part of glibc).
Build with recode produces extra package dependency, which I prefer to avoid.
> is everything already covered by iconv?
Don`t now...

> More docs could be included, for example TODO and ChangeLog*
Is it reasonable to include such files for package end-users? It seems to be
useful when accompanied with the source code only.

> Test suite not run, could do "make check" in a %check section
In your srpm it is "%check || :" -- i.e. depends nothing on it (always true)?
That what reason to do it?

> --libexecdir=%{_libdir} 
%configure provides "--libexecdir=%_libexecdir" already...

> "discriminator"
Agree, it is questionable.
May be better just: "Character sets analyzer" ? Or "auto-detector"...

> smp_mflags & disable-dependency-tracking
Will be done.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list