[Bug 167258] Review Request: up-imapproxy: University of Pittsburgh IMAP Proxy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: up-imapproxy: University of Pittsburgh IMAP Proxy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167258


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-09-08 17:53 EST -------
Review:

- rpmlint checks:
E: up-imapproxy incoherent-subsys /etc/rc.d/init.d/imapproxy in.imapproxyd
W: up-imapproxy incoherent-init-script-name imapproxy

You don't have a subsys lock file. Adding something like:

lockfile=/var/lock/subsys/imapproxy

to your initscript will fix that first error.
The other warning is safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.