[Bug 167820] Review Request: enca - Charset analyzer and discriminator

bugzilla at redhat.com bugzilla at redhat.com
Fri Sep 9 13:45:40 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enca - Charset analyzer and discriminator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167820





------- Additional Comments From ville.skytta at iki.fi  2005-09-09 09:45 EST -------
(In reply to comment #6)    
> I would prefer to follow static lib policy of the corresponding Core    
> distribution. As I understand, currently devel packages have static libs...    
    
If you don't like the guidelines, I suggest voicing your concerns on    
the fedora-packaging list.  This guideline is pretty new, and has not been    
applied everywhere yet, but that doesn't mean that it shouldn't be applied to    
new packages (unless there's a good reason not to, and "good devel stuff with   
html docs" isn't one when balanced against the potential security problems   
shipping static libs can inflict on users).  More info in the  
fedora-maintainers list archives:  
https://www.redhat.com/archives/fedora-maintainers/2005-July/thread.html  
  
  
> BTW, is there some macro (like "dist"), which can be used in "%if" to make    
> static libs build conditional?    
    
The standard --with functionality of rpmbuild should work:    
    
  %configure %{!?_with_static:--disable-static}    
  [...]    
  %files    
  [...]    
  %if 0%{?_with_static:1}    
  %{_libdir}/*.a    
  %endif    
   
   
> > external converters' mess    
> What about --disable-external ? Internal + iconv should be enough (see    
comment #4)    
    
Works for me, they can be enabled later if need be.  Note that with   
--disable-external, the now useless external converter scripts are still   
installed in libexecdir and should be manually removed in the specfile.  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list