[Bug 168032] Review Request: Gnome Timer Applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Gnome Timer Applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168032





------- Additional Comments From fedora at leemhuis.info  2005-09-11 12:30 EST -------
Please change 
>Source0:       
http://prdownloads.sourceforge.net/timerapplet/timer-applet-%{version}.tar.gz
to
Source0:       
http://download.sourceforge.net/timerapplet/timer-applet-%{version}.tar.gz
so download works in wget (after replacing version)


>%description
>Timer Applet is a countdown timer applet for the GNOME panel.
Isn't there anything more to tell? This is nearly exactly the same as in the Summary


Remove
>Requires:       gnome-panel
rpmbuild finds this requirement (libpanel-applet-2.so.0, provided by
gnome-panel-2.10.1-10.2) on its own


Mmm, this is not required but sounds okay to me:
>Provides:	timer-applet = %{version}
Maybe we should add this to the "Package Naming Guidelines" for applets that
have a differnet name upstream?


What is the reason for 
>rm -f $RPM_BUILD_ROOT%{_infodir}/dir


During build I see this:
----
for file in timer-applet-C.omf; do \
  scrollkeeper-preinstall /usr/share/gnome/help/timer-applet/C/`awk 'BEGIN {RS =
">" } /identifier/ {print $0}' ${file} | awk 'BEGIN {FS="\""} /url/ {print $2}'`
${file} ../../omf-install/${file}; \
done
I/O error : No such file or directory
touch omf_timestamp
make[3]: Leaving directory `/home/rpmqa/rpmbuild/BUILD/timer-applet-1.1.1/help/C'
Making all in fr
/home/rpmqa/rpmbuild/BUILD/timer-applet-1.1.1/help/fr
make[3]: Entering directory `/home/rpmqa/rpmbuild/BUILD/timer-applet-1.1.1/help/fr'
for file in timer-applet-fr.omf; do \
  scrollkeeper-preinstall /usr/share/gnome/help/timer-applet/fr/`awk 'BEGIN {RS
= ">" } /identifier/ {print $0}' ${file} | awk 'BEGIN {FS="\""} /url/ {print
$2}'` ${file} ../../omf-install/${file}; \
done
I/O error : No such file or directory
touch omf_timestamp
----
and this
----
for file in ./figures/*.png; do \
  basefile=`echo $file | sed -e  's,^.*/,,'`; \
  /usr/bin/install -c -m 644 $file
/var/tmp/gnome-timer-applet-1.1.1-2-root-rpmqa/usr/share/gnome/help/timer-applet/C/figures/$basefile;
\
done
/usr/bin/install: cannot stat `./figures/*.png': No such file or directory
----
Can you check what's wrong there?


(In reply to comment #0)
> I wonder if this package should be named gnome-timer-applet or
gnome-applet-timer!?
According to the Package Naming Guidelines is should be gnome-applet-timer. I
first thought we should make a exception here, because gnome-timer-applet is
closer to the upstream name and (not that important) the mandrake-package is
named gnome-timer-applet, too. But I think I changed my mind: IMHO it should be
named gnome-applet-timer.

Readers on fedora-extras-list: What's your opinion on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.