[Bug 165488] Review Request: Weather status dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Weather status dockapp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165488





------- Additional Comments From paul at city-fan.org  2005-09-15 10:03 EST -------
(In reply to comment #1)
> + the package builds in mock/x86_64     
> + rpmlint     
> W: wmapmload no-version-in-last-changelog    
> W: wmapmload-debuginfo no-version-in-last-changelog    
>      
>   These can be ignored.

They are also trivially fixed, so they might as well be fixed. The version
number is actually specified in the spec file, but the packager's editor has
word-wrapped it onto the next line. Joining the two lines together will fix the
problem, e.g.:

* Fri Jun 03 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> 2.9-1
- Initial Release

> + package name follows the guideline     
> + package follows packaging guidelines     
> + license is valid, matches upstream and is included    
> + spec file is legible and is written in American English     
> + source matches upstream     
> + Requires and BR OK     
> + files ownership OK    
>     
> Approved.  
>   
> There is no need to pack the ChangeLog in %doc, as this is mainly developper  
> information, you can drop it.

Whilst it's mainly developer information, there are a few things in there of
interest to end users. Personally I would include it.

On the other hand, I would drop the README file, which is about how to build the
app, and include instead HINTS, which is about how to run it.

> There is no need to list the man page in %files as this is done automatically.

That is not true, at least not in any version of rpm I've ever used.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.