[Bug 168168] Review request: perl-Locale-Maketext-Lexicon - Locale::Maketext::Lexicon Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Locale-Maketext-Lexicon - Locale::Maketext::Lexicon Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168168


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-16 11:00 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, not in separate file
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 and in mock for rawhide (i386)
- no explicit BR's
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets
- provides-filtering script is necessary (provided)

Notes:

- URL for Source0 doesn't work: s/www/search/
- Does CVS preserve exec permissions on source files? If not, then
  %define __perl_provides %{SOURCE1}
  won't work reliably out of CVS because %{SOURCE1} may not have exec
  permission. I'd advocate adding:
  chmod 755 %{SOURCE1}
  to the end of %prep as a safeguard

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.