[Bug 168032] Review Request: Gnome Timer Applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Gnome Timer Applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168032


fedora at leemhuis.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From fedora at leemhuis.info  2005-09-19 13:37 EST -------
APPROVED:
0d8fc37810ced0b38e6f6218c424eb80  gnome-applet-timer-1.1.1-8.fc4.src.rpm

Source matches upstream:
db9dacfa6bd35904dc88740764b1750e  timer-applet-1.1.1.tar.gz

rpmlint:
W: gnome-applet-timer non-standard-dir-in-usr libexec
(can be ignored)

Good:
- package meets naming guidelines
- package meets packaging guidelines
- URL and Source url are valid
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on mach-fc4 (x86)
- no missing BR
- no unnecessary BR
- locales use find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file because it's an applet
- scriptlets match examples from wiki

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.