[Bug 168719] Review Request: gdal

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 20 04:25:22 UTC 2005

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gdal


------- Additional Comments From rc040203 at freenet.de  2005-09-20 00:25 EST -------
Not a formal review, just some comments:

+ A lot of progress since the last iteration

The package seems basically OK to me, nevertheless there still are some major
gripes, therefore I can avoid:


- Is there a particular reason for using the internal libtiff?
I recommend using the version being shipped with FC, if possible. AFAIS, the
version shipped with FC4 seems to be sufficient, I haven't check other versions.

- Building the internal libtiff pulls in parts from the private copy of zlib
(AFAIS, they compile against the internal headers, but link against the external
# grep zlib log
/bin/sh ../../../libtool --mode=compile gcc -c -I../../../port -O2 -g -pipe
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -m32 -march=i386 -mtune=pentium4
-fasynchronous-unwind-tables -I/usr/include/netcdf-3 -I../../../port 
Using the external libtiff seems to avoid this issue.

- Something doesn't seem to be correct with mysql-support.
If building the package outside of buildroots (with mysql-devel installed),
mysql support is being built in, but I can't spot any corresponding
=> Non deterministic build results

I recommend to either switch it off (--with-mysql=no) or to make it mandatory
(BuildRequires: mysql-devel/--with-mysql).

- Similar consideration on hdf5 (hdf5 is part of FE).
If building the package outside of buildroots (with hdf5-devel installed), hdf5
support is picked up.
=> Non deterministic build results

I recommend to either switch it off (--with-hdf5=no) or to make it mandatory
(BuildRequires: hdf5-devel/--with-hdf5).

- Probably a lot of missing package deps inside of devel package.
(c.f. /usr/lib/libgdal.la)

Additional remarks:
- I recommend not to ship static libs.

- Other reviewers probably will gripe on shipping libtool archives, but my
opinion differs (This is a different story ;) ).

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the fedora-extras-list mailing list